Skip to content

Add newsletter #6 (2018-07-31) #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2018
Merged

Add newsletter #6 (2018-07-31) #47

merged 3 commits into from
Jul 31, 2018

Conversation

harding
Copy link
Collaborator

@harding harding commented Jul 28, 2018 •
edited by jnewbery
Loading

Based on #28 to include text of AJ Town's article.

Todos:

  • This assumes Bitcoin Core 0.16.2 will be released and links to the URL where its release notes should appear on BitcoinCore.org. I think that's likely, but if it doesn't happen, this will need to be updated
  • This guesses that there might be a fee spike on Monday due to the retarget tomorrow. This might need some revision. I felt like a weather forecaster writing that paragraph.

Some notes:

  • It was a slow news week, so instead of the little blurb about Bitcoin StackExchange that's been mentioned, I decided to link to some of its top questions and answers for the last month.
    • One of the answers is mine. Obviously, y'all should scrutinize that extra hard and remove it if you think it's inappropriate.
  • I changed the "Notable Bitcoin Core merges" section to "Notable commits" and trawled lnd and C-lightning for stuff. I think this solves the problem of looking too focused on Bitcoin Core.
    • You'll note there's no merges linked for C-lightning. That's because they apparently don't believe in merges---they appear to use rebases to create a completely linear commit history, and they don't link issues or PR numbers anywhere in their commit log, so I have no idea where their stuff is discussed and reviewed. (/me puts on his Technical Writers Union hat and mumbles something about developers being crazy)

jnewbery
jnewbery reviewed Jul 30, 2018
View reviewed changes
Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work as always!

I've pushed a fixup commit with a couple of small changes. If I don't hear any complaints about those changes, I'll squash and merge to master tomorrow morning.

_includes/references.md Outdated

{% assign rpc_prefix = "https://bitcoincore.org/en/doc/0.16.1" %}
[rpc fundrawtransaction]: {{rpc_prefix}}/rpc/rawtransactions/fundrawtransaction/
[rpc abandontransaction]: {{rpc_prefix}}/rpc/rawtransactions/fundrawtransaction/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link should be /rpc/wallet/abandontransaction/

_posts/en/newsletters/2018-07-31-newsletter.md Outdated

## Dashboard items

- **Fees still low:** hash rate increased difficulty by more than 10%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was eventually 14.88% 😮

_posts/en/newsletters/2018-07-31-newsletter.md

- [If you can use almost any opcode in P2SH, why can't you use them in
scriptPubKeys?][bse 76541]: in this answer, Bitcoin technical writer
David A. Harding explains why early versions of Bitcoin restricted the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

_posts/en/newsletters/2018-07-31-newsletter.md
contributors look for answers to their questions---or when we have a
few spare moments of time to help answer other people's questions. In
this new monthly feature, we highlight some of the top voted questions
and answers made there in the past month.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! 💯

_posts/en/newsletters/2018-07-31-newsletter.md Outdated
minutes, there's the possibility for a rapid increase estimated
transaction fees. We recommend being careful sending large low-fee
transactions such as consolidations until closer to the weekend when
transaction volume begins to taper off again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good. I think the phrasing can be tweaked slightly to make it read better. I'll try to do that in a fixup commit.

_posts/en/newsletters/2018-07-31-newsletter.md Outdated

## Action items

{% comment %}<!-- TODO: replace with something else if 0.16.2 not released -->{% endcomment %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was released! I'll remove this in a fixup commit.

@jnewbery
Copy link
Contributor

It was a slow news week, so instead of the little blurb about Bitcoin StackExchange that's been mentioned, I decided to link to some of its top questions and answers for the last month.

I love this new feature!

You'll note there's no merges linked for C-lightning. That's because they apparently don't believe in merges [...] and they don't link issues or PR numbers anywhere in their commit log

weird!

jnewbery and others added 2 commits July 30, 2018 15:00
@jnewbery
Add Xapo consolidation article
9081a94 
Original material by AJ Towns.
Additional content by David Harding and John Newbery.
@harding @jnewbery
Xapo Consolidation: make text includable in multiple pages
b8adf77 
Except for a couple extra invisible newline in the HTML source, renders
identically to before.  This will allow us to keep the article text
synchronised with the text in the newsletter.

- Moves text of article to _includes/
  - Adds copyright statement to top, at least until we get permission to
    MIT license
  - Defines a variable that allows changing the subhead depth
- Includes that file in the previous file
@jnewbery jnewbery mentioned this pull request Jul 30, 2018
Merged
@jnewbery jnewbery force-pushed the 2018-07-31-newsletter branch from 01ff04a to f812751 Compare July 30, 2018 19:11
@jnewbery
Copy link
Contributor

Rebased on top of update #28

@harding
Copy link
Collaborator Author

harding commented Jul 31, 2018

ACK f812751

Thanks @jnewbery for catching that copy/paste error, and I really like your improvement to the dashboard item.

@harding @jnewbery
Newsletters: add #6 (2018-07-31)
2c78695 
Material by David Harding.
Minor fixups by John Newbery.
@jnewbery jnewbery force-pushed the 2018-07-31-newsletter branch from f812751 to 2c78695 Compare July 31, 2018 13:21
@jnewbery jnewbery merged commit b156195 into bitcoinops:master Jul 31, 2018
@harding harding mentioned this pull request Sep 25, 2018
Merged
1 task
@Gustavojfe Gustavojfe mentioned this pull request May 14, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnewbery jnewbery jnewbery left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harding @jnewbery