Skip to content

Conversation

harding
Copy link
Collaborator

@harding harding commented Oct 18, 2021

No description provided.

`uniq` seems to think this header collides with another Japanese header
that looks different to me.  Fix it by manually assigning a header id.
Copy link

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to leave a review but no further trivia come to my mind. ;)

@dongcarl
Copy link
Contributor

Removed my stub, I looked into the PRs and Issues and didn't think it was that interesting of a change.

@jnewbery jnewbery force-pushed the 2021-10-20-newsletter branch from cfe52a0 to c09d229 Compare October 20, 2021 08:51
@jnewbery
Copy link
Contributor

I've done one final pass and verified that all review comments have been addressed. Thanks all!

@bitschmidty bitschmidty force-pushed the 2021-10-20-newsletter branch from c09d229 to 19dde1d Compare October 20, 2021 11:14
@bitschmidty bitschmidty merged commit 0a0f719 into bitcoinops:master Oct 20, 2021
@bitschmidty
Copy link
Contributor

Pushed a small change in the Bitcoin Core #22539 entry, squashed and merged.

Thank you @harding for the heavy lifting on authoring this week and to @ajtowns @sipa @adamjonas @gmaxwell @jnewbery @real-or-random and @jonasnick for the reviews and insights!

@ghost
Copy link

ghost commented Oct 21, 2021

Great piece as usual.

But you only mention join market 9.2, while yesterday was a critical bug fix released in 9.3. Since there is potential loss of funds, maybe you could update this newsletter with the announcement already?

https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/release-notes/release-notes-0.9.3.md

@bitschmidty
Copy link
Contributor

@MaxHillebrand updating per: #672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants