Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addButton & setRangeValue functions #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kabrio
Copy link

@kabrio kabrio commented Jul 28, 2017

Just a simple wrapper around quicksettings to be able to add buttons by calling addButton(title, function).
Also wrapped setRangeValue function from quicksettings to enable scripted value changes of sliders.
See button-setRangeValue example for demonstration.

@micahwalter
Copy link

Would be nice to see this merged...

@craftoid
Copy link
Member

Hey @kabrio —thanks for your pull request, I finally got back to work on p5.gui.
I have rewritten it quite a bit, but I will try to incorporate your suggestions / changes.

@craftoid
Copy link
Member

  1. Adding Buttons and HTML is definitely on my list... But I'd rather create those auto-magically from functions and DOM elements.
  2. In general p5.gui should magically reflect changes of the variables passed to it.
    So rather than scripting changes to the GUI, the gui should watch the variables and update accordingly...
  3. I like your randomize example a lot 👍
    I will adapt it to fit the approach outlined above

Thanks for your contribution, and sorry for the long delay!

Copy link

@Catz1301 Catz1301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely annoying to check the differences between the files. It's generally a good idea to only change what needs to be changed, and do not convert line endings before committing (unless GitHub automatically handles line endings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants