Fix error checking for log/param var lengths #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes undefined runtime behavior in case a developer used variable names for logging that are too long: 1.) The existing checks for both params and logging at startup were incorrect, because they did not look at both group and variable name. 2.) There was no check in logging CMD_GET_ITEM, potentially causing undefined runtime behavior. This change implements the same check as in the parameter framework. The issue will be detected at startup in all cases. If the debug mode for logging or parameters is enabled, the first variable that violates the condition will be printed.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes undefined runtime behavior in case a developer used variable names for logging that are too long:
1.) The existing checks for both params and logging at startup were incorrect, because they did not look at both group and variable name.
2.) There was no check in logging CMD_GET_ITEM, potentially causing undefined runtime behavior. This change implements the same check as in the parameter framework.
The issue will be detected at startup in all cases. If the debug mode for logging or parameters is enabled, the first variable that violates the condition will be printed.