Skip to content

shorten thread names #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+3 −3
Merged

shorten thread names #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bd-buffer/src/buffer/aggregate_ring_buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ impl RingBufferImpl {

let cloned_shared_data = shared_data.clone();
let flush_thread = std::thread::Builder::new()
.name(format!("bitdrift-buffer-{name}"))
.name(format!("bd-buffer-{name}"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these will go over since the name is default_buffer or whatever it is, but not sure what else to put?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP, not much we can do besides changing the default config at this point, since today they're called default_buffer_id and continuous_buffer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regardless with truncation we should be able to tell bd-buffer-defau vs bd-buffer-conti so it's good enough for this purpose

.spawn(move || cloned_shared_data.flush_thread_func())
.map_err(|e| Error::ThreadStartFailure(e.to_string()))?;

Expand Down
4 changes: 2 additions & 2 deletions bd-logger/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,10 @@ impl LoggerBuilder {
f: impl Future<Output = anyhow::Result<()>> + Send + 'static,
) -> anyhow::Result<()> {
std::thread::Builder::new()
.name("bitdrift-tokio".to_string())
.name("bd-tokio".to_string())
.spawn(move || {
tokio::runtime::Builder::new_current_thread()
.thread_name("bitdrift-tokio-worker")
.thread_name("bd-tokio-worker")
.enable_all()
.build()?
.block_on(async {
Expand Down
Loading