Use private host for auth-based requests #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-) Updated examples
updated version
vigan-abd
reviewed
Aug 23, 2022
bfxapi/websockets/bfx_websocket.py
Outdated
| """ | ||
|
|
||
| def __init__(self, API_KEY=None, API_SECRET=None, host='wss://api-pub.bitfinex.com/ws/2', | ||
| def __init__(self, host, API_KEY=None, API_SECRET=None, |
There was a problem hiding this comment.
hmm would this be breaking change? previously host was optional
There was a problem hiding this comment.
hello vigan, thanks for checking
BfxWebsocket is called only from https://github.com/bitfinexcom/bitfinex-api-py/blob/master/bfxapi/client.py#L24 and in that function ws_host defaults to WS_HOST. I wanted to avoid that duplicate hardcoded URL, but I think you're right and it's safer if I use WS_HOST also there so if our users have some highly customized implementation we do not break anything
vigan-abd
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated code to change private host for auth-based requests and updated examples
Breaking changes:
New features:
Fixes:
PR status: