Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Compose Migration #207

Merged
merged 59 commits into from
Feb 25, 2024
Merged

Jetpack Compose Migration #207

merged 59 commits into from
Feb 25, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Feb 22, 2024 •
edited
Loading

See ArnyminerZ#1 for more information

Closes #192

ArnyminerZ and others added 30 commits November 20, 2023 13:22
@ArnyminerZ
Note
050b0df 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ
Migrate to Kotlin DSL (#19)
6947495 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@sunkup
Upgrade all dependencies (#22)
1264c3e
@ArnyminerZ
Upgrade to Android 14 (#21)
f3453d4 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@sunkup
Rewrite CredentialsFragment to compose (#26)
6b3f4c6
@sunkup
Update import (#27)
60ae9c7
@ArnyminerZ
Update README.md
3d4d744
@sunkup @ArnyminerZ
Fix NPE on adding subscription (#33)
200dda5 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Arnau Mora <arnyminerz@proton.me>
@sunkup
Make CredentialsFragment into a composable (#35)
e35441c
@ArnyminerZ
Using regular ubuntu image
d08ca0f 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@sunkup
Migrate SubscriptionSettingsFragment to compose (#29)
6422ded
@ArnyminerZ @sunkup
Migrate AddCalendarValidationFragment to Jetpack Compose (#31)
1cfc966 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ @sunkup
Migrate AddCalendarEnterUrlFragment to Jetpack Compose (#38)
290d826 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@sunkup
Migrate AddCalendarDetailsFragment to compose (#40)
d15ceb3
@ArnyminerZ
Upgrade AGP to 8.2.1 (#42)
c2622ae 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ @sunkup
Upgrade Kotlin, KSP, Compose and others (#43)
7d5f454 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ @sunkup
Migrate AddCalendarActivity to Jetpack Compose (#45)
1254fc9 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ
Added missing line break (#52)
ce33e87
@ArnyminerZ
Remove unused view and layout (#54)
ea1a1c0 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Added Dependabot (#51)
efb56d7
@dependabot
Bump github/codeql-action from 2 to 3 (#62)
c0b4d13 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 3 to 4 (#61)
aba4a85 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/setup-java from 3 to 4 (#58)
9be039f 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump joda-time:joda-time from 2.12.5 to 2.12.6 (#56)
4af5f64 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump androidx.work:work-testing from 2.8.1 to 2.9.0 (#60)
840a4ee 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ArnyminerZ
Using BOM for OkHttp and downgrade to stable (#64)
1a9d53e 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@sunkup
Migrate EditCalendarActivity to jetpack compose (#46)
b399a43
@dependabot
Bump actions/cache from 3 to 4 (#65)
7f03890 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump com.android.tools.build:gradle from 8.2.1 to 8.2.2 (#66)
05ef0c8 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump androidx.compose.runtime:runtime-livedata from 1.5.4 to 1.6.0 (#78)
ad11020 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 27 commits January 29, 2024 14:13
@dependabot @ArnyminerZ
Bump gradle/gradle-build-action from 2 to 3 (#82)
ea169ef 
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arnau Mora <arnyminerz@proton.me>
@sunkup
Fix: Can't add subscription after going back once (#83)
231af22
@ArnyminerZ
Update ical4android and cert4android (#73)
7ae178c 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ
Cleanup of Dialogs (#67)
2239023 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@dependabot @ArnyminerZ
Bump actions/upload-artifact from 2 to 4 (#63)
ff6ee1c 
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ @sunkup
Migrate DonateDialogFragment to Jetpack Compose (#75)
deb9cad 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ @sunkup
Final layout cleanup (#68)
d796063 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ
Ensured toast error is never null (#91)
36c05dc 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Crash when going back into CalendarListActivity (standard flavour) (#…
b512a84 
…90)

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@sunkup
Migrate ColorPickerActivity to Jetpack Compose (closes #53, #87) (#94)
40cbf90
@dependabot
Bump androidx.compose:compose-bom from 2024.01.00 to 2024.02.00 (#96)
e629969 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump androidx.compose.runtime:runtime-livedata from 1.6.0 to 1.6.1 (#95)
b2f42f1 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump joda-time:joda-time from 2.12.6 to 2.12.7 (#93)
6ca6a5b 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sunkup @ArnyminerZ
Edit Subscription: requires-auth toggle and credential fields trigger…
3dd3d02 
… save-dismiss mechanism (#92)

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ
Removed package definition from manifest (#101)
8a422db 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@dependabot
Bump com.maxkeppeler.sheets-compose-dialogs:core from 1.2.1 to 1.3.0 (#…
0ffe47d 
…103)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ArnyminerZ @sunkup
Use compose theming engine, (drop compatibility MdcTheming etc) (#48)
0750818 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ
Migrated to Gradle Version Catalog (#99)
d7ec7bf 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@sunkup
Check if we can reuse more composables and improve project structure (#…
3bf7b63 
…106)
@dependabot
Bump aboutLibs from 10.7.0 to 10.10.0 (#108)
1759b40 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump org.jetbrains.kotlinx:kotlinx-coroutines-android from 1.7.3 to 1…
77ed325 
….8.0 (#110)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sunkup
Migrate to Material 3 (#109)
fc83f5a
@dependabot
Bump compose-ui from 1.6.1 to 1.6.2 (#111)
769414c 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump androidx.compose.material:material-icons-extended from 1.6.1 to …
5cda55b 
…1.6.2 (#112)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @ArnyminerZ
Bump androidx.compose.runtime:runtime-livedata from 1.6.1 to 1.6.2 (#113
aa9bc7d 
)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ @sunkup
Quickfix for pull to refresh (#114)
7850a01 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ @sunkup
Fix warnings (#115)
81df75f 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Co-authored-by: Sunik Kupfer <kupfer@bitfire.at>
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rfc2822 rfc2822 self-requested a review February 25, 2024 21:14
@rfc2822 rfc2822 merged commit d833b76 into bitfireAT:dev Feb 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 Awaiting requested review from rfc2822

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Major ICSx⁵ rewrite
4 participants
@ArnyminerZ @CLAassistant @rfc2822 @sunkup