Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error dialog in subscriptions list instead of edit #300

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Show error dialog in subscriptions list instead of edit #300

merged 3 commits into from
Apr 30, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ
Error dialog now shows on CalendarListActivity
753435f 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ
Simplified notifications
12d2098 
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Apr 28, 2024
@ArnyminerZ ArnyminerZ requested a review from sunkup April 28, 2024 10:24
@ArnyminerZ ArnyminerZ self-assigned this Apr 28, 2024
@ArnyminerZ ArnyminerZ linked an issue Apr 28, 2024 that may be closed by this pull request
Allow to refresh from error dialog #299
Closed
@ArnyminerZ ArnyminerZ marked this pull request as ready for review April 28, 2024 10:24
@ArnyminerZ
Merge remote-tracking branch 'origin/dev' into 299-allow-to-refresh-f…
c2779fd 
…rom-error-dialog

# Conflicts:
#	app/src/main/java/at/bitfire/icsdroid/ui/views/EditCalendarActivity.kt
sunkup
sunkup approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

Would be cool if ICSx5 could dismiss the notification on it's own if there was a successful sync before the user gets the chance to tap on it. But we can leave that for another PR.

@sunkup sunkup merged commit 073a08c into dev Apr 30, 2024
7 checks passed
@sunkup sunkup deleted the 299-allow-to-refresh-from-error-dialog branch April 30, 2024 09:15
@ArnyminerZ ArnyminerZ mentioned this pull request Apr 30, 2024
Closed
@ArnyminerZ
Copy link
Member Author

See #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to refresh from error dialog
2 participants
@ArnyminerZ @sunkup