WIP: Customizable alarms per subscription

[ArnyminerZ]

Closes #1

Bugs:

• The alerts removal for when the "ignore embed alarms" option is checked only works the first time you add the calendar. This is caused by ProcessEventsTask:
  

  icsx5/app/src/main/java/at/bitfire/icsdroid/ProcessEventsTask.kt

  Line 87 in a52b5a3

  Log.i(Constants.TAG, "Calendar has not been modified since last sync")

  
  Since the calendar is technically not modified, only locally, onNotModified is called. There should be logic to handle changes to the ignore embed alarms switch, which add back again all the alarms.

TODO:

• Custom reminders only get stored for the synchronization, they don't get added to the events.

[rfc2822]

I wonder whether we should use queryEvents, which puts all events as data objects into memory. There may be 100.000 events, then we'd have 100.000 objects in the list.

---

I suggest to move the "default alarm" processing from LocalCalendar (which I think should just store the setting and handle putting Events into the Android calendar without further logic) to ProcessEventsTask. We could use an alarm algorithm like this in ProcessEventsTask.processEvents():

• Call a new method updateAlarms(event) before LocalEvent(calendar, event).add() and before localEvent.update(event).
• updateAlarms(event):
  1. If neither ignoreEmbeddedAlerts nor defaultAlarmMinutes is set, do nothing.
  2. Otherwise:
  • If ignoreEmbeddedAlerts is set, remove existing alarms from the event.
  • If defaultAlarmMinutes is set, add an alarm to the event.

With this algorithm we wouldn't have to look for already existing alarms and rewrite them. Instead we would update alarms only when downloaded events are processed; and changing the settings would force downloading the events again.

What do you think?

[ArnyminerZ]

@rfc2822 Take a look at it, haven't tested it, but should work

[rfc2822]

Thanks, I have tested it and it seems to work fine. :) Definitely something users (including myself) can use.

Can we get rid of the firstCheck thing somehow? Looks like there should be a more clean solution for that.

[rfc2822]

Nice, thanks, lets try it out :)