Database UI threading #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
|
Would it be possible to merge these changes directly into #110? If I understand it correctly, it shouldn't increase the amount of lines because it's just a change of the model/view/result pattern to match https://github.com/orgs/bitfireAT/discussions/2 |
|
It should, I've opened the PR to merge into |
rfc2822
added a commit
that referenced
this pull request
Feb 17, 2023
* Removed permissions requesting Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Migrated loading to database Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Minor changes * `add` returns ids Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Migrated creation to database Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Added update method Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Changed ViewModel Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Removed active switch Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Migrated edit to database Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Rework EditCalendarActivity - use explicit EXTRA_SUBSCRIPTION_ID - use ViewModelProvider.Factory instead of custom loadSubscription() - create one-two-one relationship between Subscription and Credential * Added permission extra Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Moved permission request Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Added permission required Snackbar Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Fixed permission request Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Added `showCalendarPermissionNotification` Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Added notification permission requests Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Added calendar permission notification Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Changed threading (#112) Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> * Change model/view/result pattern to states (LiveData) * Don't ask to enable sync framework auto-sync because we don't use the sync framework anymore * Remove unneeded string --------- Signed-off-by: Arnau Mora <arnyminer.z@gmail.com> Co-authored-by: Ricki Hirner <hirner@bitfire.at>
rfc2822
pushed a commit
that referenced
this pull request
Feb 25, 2024
* Note Signed-off-by: Arnau Mora <arnyminerz@proton.me> * Migrate to Kotlin DSL (#19) Signed-off-by: Arnau Mora <arnyminerz@proton.me> * Upgrade all dependencies (#22) * Upgrade to Android 14 (#21) Signed-off-by: Arnau Mora <arnyminerz@proton.me> * Rewrite CredentialsFragment to compose (#26) * Update import (#27) * Update README.md * Fix NPE on adding subscription (#33) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Arnau Mora <arnyminerz@proton.me> * Make CredentialsFragment into a composable (#35) * Using regular ubuntu image Signed-off-by: Arnau Mora <arnyminerz@proton.me> * Migrate SubscriptionSettingsFragment to compose (#29) * Migrate `AddCalendarValidationFragment` to Jetpack Compose (#31) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Migrate `AddCalendarEnterUrlFragment` to Jetpack Compose (#38) Signed-off-by: Arnau Mora <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Migrate AddCalendarDetailsFragment to compose (#40) * Upgrade AGP to 8.2.1 (#42) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Upgrade Kotlin, KSP, Compose and others (#43) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Migrate `AddCalendarActivity` to Jetpack Compose (#45) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Added missing line break (#52) * Remove unused view and layout (#54) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Added Dependabot (#51) * Bump github/codeql-action from 2 to 3 (#62) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3 to 4 (#61) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/setup-java from 3 to 4 (#58) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump joda-time:joda-time from 2.12.5 to 2.12.6 (#56) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump androidx.work:work-testing from 2.8.1 to 2.9.0 (#60) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Using BOM for OkHttp and downgrade to stable (#64) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Migrate EditCalendarActivity to jetpack compose (#46) * Bump actions/cache from 3 to 4 (#65) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.android.tools.build:gradle from 8.2.1 to 8.2.2 (#66) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump androidx.compose.runtime:runtime-livedata from 1.5.4 to 1.6.0 (#78) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump androidx.compose:compose-bom from 2023.10.01 to 2024.01.00 (#79) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.google.accompanist:accompanist-themeadapter-material from 0.32.0 to 0.34.0 (#80) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arnau Mora <arnyminerz@proton.me> * Bump gradle/gradle-build-action from 2 to 3 (#82) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arnau Mora <arnyminerz@proton.me> * Fix: Can't add subscription after going back once (#83) * Update ical4android and cert4android (#73) Signed-off-by: Arnau Mora <arnyminerz@proton.me> * Cleanup of Dialogs (#67) Signed-off-by: Arnau Mora <arnyminerz@proton.me> Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Bump actions/upload-artifact from 2 to 4 (#63) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arnau Mora <arnyminerz@proton.me> * Migrate `DonateDialogFragment` to Jetpack Compose (#75) Signed-off-by: Arnau Mora <arnyminerz@proton.me> Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Final layout cleanup (#68) Signed-off-by: Arnau Mora <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Ensured toast error is never null (#91) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Crash when going back into `CalendarListActivity` (standard flavour) (#90) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Migrate ColorPickerActivity to Jetpack Compose (closes #53, #87) (#94) * Bump androidx.compose:compose-bom from 2024.01.00 to 2024.02.00 (#96) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump androidx.compose.runtime:runtime-livedata from 1.6.0 to 1.6.1 (#95) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump joda-time:joda-time from 2.12.6 to 2.12.7 (#93) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Edit Subscription: requires-auth toggle and credential fields trigger save-dismiss mechanism (#92) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Arnau Mora Gras <arnyminerz@proton.me> * Removed package definition from manifest (#101) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Bump com.maxkeppeler.sheets-compose-dialogs:core from 1.2.1 to 1.3.0 (#103) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Use compose theming engine, (drop compatibility MdcTheming etc) (#48) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Signed-off-by: Arnau Mora <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Migrated to Gradle Version Catalog (#99) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> * Check if we can reuse more composables and improve project structure (#106) * Bump aboutLibs from 10.7.0 to 10.10.0 (#108) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.jetbrains.kotlinx:kotlinx-coroutines-android from 1.7.3 to 1.8.0 (#110) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Migrate to Material 3 (#109) * Bump compose-ui from 1.6.1 to 1.6.2 (#111) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump androidx.compose.material:material-icons-extended from 1.6.1 to 1.6.2 (#112) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump androidx.compose.runtime:runtime-livedata from 1.6.1 to 1.6.2 (#113) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arnau Mora <arnyminerz@proton.me> * Quickfix for pull to refresh (#114) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> * Fix warnings (#115) Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> --------- Signed-off-by: Arnau Mora <arnyminerz@proton.me> Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sunik Kupfer <kupfer@bitfire.at> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed threading of all View Models so they don't have any callbacks, just states are used.
Relates to #110