Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Divider property to HourMinuteSeparator in BitTimePickerClassStyles #7785

Closed
Cyrus-Sushiant opened this issue Jun 14, 2024 · 0 comments · Fixed by #7812
Closed

Rename Divider property to HourMinuteSeparator in BitTimePickerClassStyles #7785

Cyrus-Sushiant opened this issue Jun 14, 2024 · 0 comments · Fixed by #7812
Assignees
@Cyrus-Sushiant
Labels
area / BlazorUI
Milestone
058 - Jun 2024 - 2

Comments

@Cyrus-Sushiant
Copy link
Member

The current property named 'Divider' in BitTimePickerClassStyles is a bit ambiguous. It would be clearer if it were renamed to 'HourMinuteSeparator' to better reflect its purpose and usage.
@msynk msynk added this to the 058 - Jun 2024 - 2 milestone Jun 14, 2024
@msynk msynk moved this to In Progress in bit platform Jun 14, 2024
Cyrus-Sushiant added a commit to Cyrus-Sushiant/bitplatform that referenced this issue Jun 19, 2024
@Cyrus-Sushiant
Rename Divider property in BitTimePickerClassStyles (bitfoundation#7785)
7ebdc32
@Cyrus-Sushiant Cyrus-Sushiant mentioned this issue Jun 19, 2024
Merged
msynk pushed a commit that referenced this issue Jun 19, 2024
@Cyrus-Sushiant
feat(blazorui): rename Divider property in BitTimePickerClassStyles #…
c5b6533 
…7785 (#7812)
@github-project-automation github-project-automation bot moved this from In Progress to Done in bit platform Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyrus-Sushiant Cyrus-Sushiant

Labels
area / BlazorUI
Projects
bit platform
Status: Done
Milestone
058 - Jun 2024 - 2
Development

Successfully merging a pull request may close this issue.

Rename Divider property in BitTimePickerClassStyles (#7785) Cyrus-Sushiant/bitplatform
2 participants
@msynk @Cyrus-Sushiant