Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BitButton and friends to be type="submit" in a form via default #2872

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Fix BitButton and friends to be type="submit" in a form via default #2872

merged 3 commits into from
Aug 3, 2022

Conversation

linkdotnet
Copy link
Contributor

@linkdotnet linkdotnet commented Aug 3, 2022

this closes #2874

This PR addressed the issue, which was in the discussion #2866 .

I took the liberty and created a small PR, which might go in the right direction. Feedback very welcome.

Copy link
Member

@msynk msynk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx a lot, great job 🚀🚀🚀

@linkdotnet
Copy link
Contributor Author

tnx a lot, great job 🚀🚀🚀

Thanks as well for the super good support. I will leave it up to you guys whether or not you want to merge this. Or better when ;)

@msynk
Copy link
Member

msynk commented Aug 3, 2022

tnx a lot, great job 🚀🚀🚀

Thanks as well for the super good support. I will leave it up to you guys whether or not you want to merge this. Or better when ;)

oh ofc, we are going to merge it (squash it here😉)

@msynk msynk merged commit f2aac74 into bitfoundation:develop Aug 3, 2022
@linkdotnet linkdotnet deleted the fix/btn-in-form branch August 5, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BitButton should trigger form onsubmit when inside a form
3 participants