Skip to content

Conversation

rociollanes
Copy link
Contributor

No description provided.

@rociollanes rociollanes requested a review from marino-martin May 29, 2024 14:53
@rociollanes rociollanes self-assigned this May 29, 2024
const data = useFooter()
const dataSubscription = data?.allStrapiLayout?.nodes[0]?.footer?.subscription
const subscriptionUrl = dataSubscription?.url
const subscriptionLanding = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.landing_page?.slug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aca no iria data?.allStrapi... ya que lo tenes en la constante dataSubscription

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cierto! Ahi corrijo!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borrar la constante dataSubscription, ya que asi no se usa mas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La está usando para mostrar el texto, que es dataSubscription.title

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok..entonces reemplazar

const subscriptionUrl = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.url
const subscriptionLanding = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.landing_page?.slug

por

const subscriptionUrl = dataSubscription?.url
const subscriptionLanding = dataSubscription?.landing_page?.slug

para no repetir codigo

const data = useFooter()
const dataSubscription = data?.allStrapiLayout?.nodes[0]?.footer?.subscription
const subscriptionUrl = dataSubscription?.url
const subscriptionLanding = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.landing_page?.slug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borrar la constante dataSubscription, ya que asi no se usa mas

const data = useFooter()
const dataSubscription = data?.allStrapiLayout?.nodes[0]?.footer?.subscription
const subscriptionUrl = dataSubscription?.url
const subscriptionLanding = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.landing_page?.slug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok..entonces reemplazar

const subscriptionUrl = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.url
const subscriptionLanding = data?.allStrapiLayout?.nodes[0]?.footer?.subscription?.landing_page?.slug

por

const subscriptionUrl = dataSubscription?.url
const subscriptionLanding = dataSubscription?.landing_page?.slug

para no repetir codigo

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@marino-martin marino-martin merged commit 99f8224 into dev May 29, 2024
@GonzalezMaxi GonzalezMaxi deleted the SBIT-266 branch August 26, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants