SBIT-306: fix components #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GonzalezMaxi
commented
Jun 19, 2024
GonzalezMaxi
commented
- add seo in LandingPage
- modify structure and styles into components
- add width & height prop in images
- add validations for links
marino-martin
requested changes
Jun 19, 2024
src/components/Banner/Banner.js
Outdated
| {image?.url ? ( | ||
| <img | ||
| src={theme === "dark" && imageDark ? imageDark?.url : image?.url} | ||
| <img src={theme === "dark" && imageDark ? imageDark?.url : image?.url} |
There was a problem hiding this comment.
Creo que estaba asi, pero se deberia usar gatsby image en lugar de img
| <div className="card_item d-flex mb-2 gap-2" key={item.id}> | ||
| {item?.icon && ( | ||
| <div className="card_item"> | ||
| <img className="d-block" |
There was a problem hiding this comment.
lo mismo que antes, usar GatsbyImage
|
marino-martin
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.