Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/argo-cd] ArgoCD repo-server NetworkPolicy uses ApplicationSet values #27108

Closed
tmarback opened this issue Jun 12, 2024 · 3 comments · Fixed by #27450
Closed

[bitnami/argo-cd] ArgoCD repo-server NetworkPolicy uses ApplicationSet values #27108

tmarback opened this issue Jun 12, 2024 · 3 comments · Fixed by #27450
Assignees
Labels
argo-cd solved tech-issues The user has a technical issue about an application triage Triage is needed

Comments

@tmarback
Copy link

Name and Version

bitnami/argo-cd 6.4.6

What architecture are you using?

amd64

What steps will reproduce the bug?

  1. Install the chart with repoServer.networkPolicy.enabled: true

Are you using any custom parameters or values?

repoServer.networkPolicy.enabled: true

What is the expected behavior?

The NetworkPolicy resource generated for the repo-server component should have the values specified in the repoServer.networkPolicy section.

What do you see instead?

It has the values from the applicationSet.networkPolicy section instead.

Additional information

See templates/repo-server/networkpolicy.yaml in the current latest commit - all the templates use .Values.applicationSet instead of .Values.repoServer.

@tmarback tmarback added the tech-issues The user has a technical issue about an application label Jun 12, 2024
@github-actions github-actions bot added the triage Triage is needed label Jun 12, 2024
@javsalgar javsalgar changed the title ArgoCD repo-server NetworkPolicy uses ApplicationSet values [bitnami/argo-cd] ArgoCD repo-server NetworkPolicy uses ApplicationSet values Jun 12, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for reporting! As you spotted the issue, would you like to submit a PR setting the correct references?

@Jeremy-Boyle
Copy link
Contributor

Ill do a PR for this, i have some changes that need to be addressed as well.

Jeremy-Boyle added a commit to Jeremy-Boyle/charts that referenced this issue Jun 19, 2024
…ting refrencing applicationSet instead of repoServer

Signed-off-by: Jeremy-Boyle <9406398+Jeremy-Boyle@users.noreply.github.com>
@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd solved tech-issues The user has a technical issue about an application triage Triage is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants