Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/spring-cloud-dataflow] Adding annotations to stream deployment #28155

Closed
dadacom379 opened this issue Jul 18, 2024 · 5 comments
Closed
Assignees
Labels

Comments

@dadacom379
Copy link

Name and Version

bitnami/spring-cloud-dataflow 30.0.0

What is the problem this feature will solve?

At the moment it is not possible to add annotations to a deployment. In my example trying to put in place a Kubernetes reloader when a configMap or secret is changing

What is the feature you are proposing to solve the problem?

Is it possible to add a feature like the existing one?

deployer..kubernetes.job-annotations=reloader.stakater.com/auto:"true"
deployer.
.kubernetes.pod-annotations=reloader.stakater.com/auto:"true"
deployer..kubernetes.service-annotations=reloader.stakater.com/auto:"true"
Like a configuration that could be deployer.
.kubernetes.deployment-annotations=reloader.stakater.com/auto:"true"

Then when a injected configMap or secret change the deployment restart

image

?

What alternatives have you considered?

At this time the alternative was to execute a Kubectl command

  • kubectl annotate deployment --all reloader.stakater.com/auto="true" -n my-namespace
@dadacom379 dadacom379 changed the title [] Adding annotations to stream deployment [bitnami/spring-cloud-dataflow] Adding annotations to stream deployment Jul 18, 2024
@github-actions github-actions bot added the triage Triage is needed label Jul 18, 2024
@javsalgar
Copy link
Contributor

Hi!

In other charts we have the deploymentAnnotations or statefulsetAnnotations value depending on the application. Would you like to submit a PR adding support for this value?

Copy link

github-actions bot commented Aug 4, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Aug 4, 2024
@dadacom379
Copy link
Author

dadacom379 commented Aug 6, 2024 via email

@javsalgar javsalgar removed the stale 15 days without activity label Aug 6, 2024
Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Aug 22, 2024
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants