[bitnami/keycloak] fix: 🐛 🔒 Expose missing ports in deployment spec and fix headless service #25110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd fix headless service Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
jotamartos
approved these changes
Apr 15, 2024
djjudas21
pushed a commit
to djjudas21/bitnami-charts
that referenced
this pull request
Apr 17, 2024
…nd fix headless service (bitnami#25110) Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: Jonathan Gazeley <me@jonathangazeley.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com
Description of the change
This PR adds to the deployment spec the ports that were missing, such as the discovery port. It also changes the headless service to not use the service ports but the container ports instead.
Benefits
Improved security of the application
Possible drawbacks
n/a
Applicable issues
Additional information
Thanks to @jlmartinnavarro
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm