[bitnami/keycloak]: add url env vars to fix admin ingress access #25386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFreezeex
force-pushed
the
keycloak-fix-admin-ingress-env
branch
2 times, most recently
from
ddc7de3
to
92a38c8
Compare
|
Thanks for your contribution, due to some changes in our test suite it is needed to rebase from main and the update the PR, could you please do that? Thanks beforehand and sorry for the inconvenience. |
MrFreezeex
force-pushed
the
keycloak-fix-admin-ingress-env
branch
from
92a38c8
to
763b079
Compare
Sure, no worries! |
carrodher
added
verify
jotamartos
reviewed
Apr 29, 2024
|
Hi @MrFreezeex, Thanks for creating this PR. Could you please take a look at my suggestions? I think the URL is not generated properly. |
Replace KC_HOSTNAME_ADMIN by KC_HOSTNAME_ADMIN_URL to include the scheme (http or https) and add KC_HOSTNAME_URL for the frontend to function correctly. These variable allow the front to function correctly if we have the tls option enabled. Before this commit the front was always attempting to load some resources over http while it may be exposed in https. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr>
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr>
MrFreezeex
force-pushed
the
keycloak-fix-admin-ingress-env
branch
from
e246ba1
to
36eaa7f
Compare
Woops indeed sorry for that and thanks for catching it! I just fixed it |
jotamartos
approved these changes
Apr 29, 2024
matheusmgon
pushed a commit
to matheusmgon/charts
that referenced
this pull request
May 2, 2024
…nami#25386) * [bitnami/keycloak]: add url env vars to fix admin ingress access Replace KC_HOSTNAME_ADMIN by KC_HOSTNAME_ADMIN_URL to include the scheme (http or https) and add KC_HOSTNAME_URL for the frontend to function correctly. These variable allow the front to function correctly if we have the tls option enabled. Before this commit the front was always attempting to load some resources over http while it may be exposed in https. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> * [bitnami/keycloak]: fix license header to fix the CI Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon
pushed a commit
to matheusmgon/charts
that referenced
this pull request
May 3, 2024
…nami#25386) * [bitnami/keycloak]: add url env vars to fix admin ingress access Replace KC_HOSTNAME_ADMIN by KC_HOSTNAME_ADMIN_URL to include the scheme (http or https) and add KC_HOSTNAME_URL for the frontend to function correctly. These variable allow the front to function correctly if we have the tls option enabled. Before this commit the front was always attempting to load some resources over http while it may be exposed in https. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> * [bitnami/keycloak]: fix license header to fix the CI Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> Signed-off-by: Matheus Goncalves <matheus.goncalves@bexio.com>
matheusmgon
pushed a commit
to matheusmgon/charts
that referenced
this pull request
May 7, 2024
…nami#25386) * [bitnami/keycloak]: add url env vars to fix admin ingress access Replace KC_HOSTNAME_ADMIN by KC_HOSTNAME_ADMIN_URL to include the scheme (http or https) and add KC_HOSTNAME_URL for the frontend to function correctly. These variable allow the front to function correctly if we have the tls option enabled. Before this commit the front was always attempting to load some resources over http while it may be exposed in https. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> * [bitnami/keycloak]: fix license header to fix the CI Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
matheusmgon
pushed a commit
to matheusmgon/charts
that referenced
this pull request
May 8, 2024
…nami#25386) * [bitnami/keycloak]: add url env vars to fix admin ingress access Replace KC_HOSTNAME_ADMIN by KC_HOSTNAME_ADMIN_URL to include the scheme (http or https) and add KC_HOSTNAME_URL for the frontend to function correctly. These variable allow the front to function correctly if we have the tls option enabled. Before this commit the front was always attempting to load some resources over http while it may be exposed in https. Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> * [bitnami/keycloak]: fix license header to fix the CI Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> --------- Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr> Signed-off-by: Matheus Gonçalves <mathmgoncalves@gmail.com>
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Replace KC_HOSTNAME_ADMIN by KC_HOSTNAME_ADMIN_URL to include the scheme (http or https) and add KC_HOSTNAME_URL for the frontend to function correctly. These variable allow the front to function correctly if we have the tls option enabled. Before this commit the front was always attempting to load some resources over http while it may be exposed in https.
Benefits
Keycloak admin ingress works if tls/https is configured
Possible drawbacks
If some users defined
KC_HOSTNAMEorKC_HOSTNAME_URLin extraEnv it could prevent keycloak to start, I reduced the risk by adding this variable only if the ingress is not enabled thoughApplicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm