Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] Fix issue on how to provision access to all topics / groups #27877

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

florian-besser
Copy link
Contributor

Fixes #27480

Description of the change

Allow provisioning of access to al topics / groups, update documentation to go along with it

Benefits

You can now provision access to all groups instead of incorrectly provisioning access to the group or topic called '*'

Possible drawbacks

I'm not aware of any, given that the current way of provisioning doesn't seem to work.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [ X] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Fixes bitnami#27480

Signed-off-by: Florian Besser <flo@gsgasset.com>
@github-actions github-actions bot added kafka triage Triage is needed labels Jul 10, 2024
@github-actions github-actions bot requested a review from javsalgar July 10, 2024 10:25
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jul 10, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jul 10, 2024
@github-actions github-actions bot removed the request for review from javsalgar July 10, 2024 19:22
@github-actions github-actions bot requested a review from alemorcuq July 10, 2024 19:22
carrodher and others added 4 commits July 18, 2024 12:33
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@florian-besser
Copy link
Contributor Author

Any inputs @alemorcuq / @carrodher (since I see you merging main into this PR)

@alemorcuq alemorcuq merged commit 6535067 into bitnami:main Jul 23, 2024
10 checks passed
jdaln pushed a commit to jdaln/charts that referenced this pull request Jul 24, 2024
…groups (bitnami#27877)

* Fix issue on how to provision access to all topics / groups

Fixes bitnami#27480

Signed-off-by: Florian Besser <flo@gsgasset.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Florian Besser <flo@gsgasset.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
datbui pushed a commit to datbui/charts that referenced this pull request Jul 24, 2024
…groups (bitnami#27877)

* Fix issue on how to provision access to all topics / groups

Fixes bitnami#27480

Signed-off-by: Florian Besser <flo@gsgasset.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

---------

Signed-off-by: Florian Besser <flo@gsgasset.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kafka solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka helm chart examples lead to literal '*' instead of wildcard
5 participants