-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/opensearch] Fix plugins installation #29586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juan131 <jariza@vmware.com>
github-actions
bot
added
opensearch
verify
Execute verification workflow for these changes
bitnami
labels
Sep 24, 2024
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
andresbono
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes needed for bitnami/elasticsearch as well?
They'll be implemented in a separate PR |
Please, check the CI result, something is wrong with the config directory |
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
andresbono
approved these changes
Sep 24, 2024
3 tasks
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Michael Faherty <80599490+mike12806@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes the conditions under init containers are rendered in OpenSearch pods and it fixes custom plugins installation by ensuring we respect original container permissions on
plugins
andconfig
directories via the "copy-default-plugins" init container.Benefits
User can install custom plugins without issues.
Possible drawbacks
None
Applicable issues
Additional information
N/A
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.