Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/zookeeper] allow for overriding namespace in zookeeper helm chart #3881

Merged
merged 6 commits into from
Oct 7, 2020

Conversation

monicaruttle
Copy link
Contributor

Description of the change

Allow for overriding the namespace that the ZooKeeper helm chart resources use.

Benefits

When ZooKeeper is included as a dependency of another helm chart, the preferred behaviour may be for it to be released into a different namespace than the parent. This change will allow for the parent chart values to override the namespace.

Possible drawbacks

Unknown

Applicable issues

Additional information

By default behaviour will not change from taking the Release.Namespace value for the namespace.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

@glothriel
Copy link
Contributor

glothriel commented Oct 4, 2020

@juan131 I think you may be interested in this one :-)

Personally I like the idea, with some changes:

  • I've seen somewhere (charts/stable?) similar approach, but the field there was named namespaceOverride, for some reason I like it more
  • I'd extract this logic to a template

Note: I'm not Bitnami employee nor this repo co-maintainer, this is only my opinion, so don't treat this propositions as obligatory.

Copy link
Contributor

@miguelaeh miguelaeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @monicaruttle ,
Thank you very much for the PR!
Please take a look at the files carefully, there are some places where the namespace is used that also need to be changed.
Apart from that, I agree with @glothriel in use namespaceOverride and a template to select the namespace instead of repeating the logic in all the files.

bitnami/zookeeper/templates/statefulset.yaml Show resolved Hide resolved
Copy link
Contributor

@dani8art dani8art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @monicaruttle thanks for applying the changes.

Please, take a look at my comments.

bitnami/zookeeper/Chart.yaml Outdated Show resolved Hide resolved
Co-authored-by: Daniel Arteaga <dani8art.da@gmail.com>
Copy link
Contributor

@dani8art dani8art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dani8art dani8art merged commit 01b1359 into bitnami:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants