Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item.List splice method does not convert inserted elements to Item type #253

Merged
merged 1 commit into from
Feb 26, 2013

Conversation

daffl
Copy link
Contributor

@daffl daffl commented Feb 25, 2013

New elements inserted List of Observe inheritor with splice method is not converted to base class.

push and unshift do the conversion.

http://jsfiddle.net/qYdwR/646/

@wclr
Copy link
Contributor Author

wclr commented Jan 26, 2013

Have you looked at fiddle?

@daffl
Copy link
Contributor

daffl commented Feb 20, 2013

Yep. And seeing the problem. Will fix for 1.1.5 which should be out around the middle/end of March.

@ghost ghost assigned daffl Feb 25, 2013
daffl added a commit that referenced this pull request Feb 26, 2013
Item.List splice method does not convert inserted elements to Item type
@daffl daffl merged commit 499036c into master Feb 26, 2013
@daffl daffl deleted the list-splice-convert-253 branch February 26, 2013 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants