Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .attr() when evaluating errors in validations #437

Closed
wants to merge 1 commit into from

Conversation

airhadoken
Copy link
Contributor

#410 in pull request form

In order to make it possible to bind a can.compute to error evaluations, switch the [attr] access of attributes to .attr(attr)

I've been using this for a few weeks on reciprocity/ggrc-core and it seems to be working out without unintended side effects.

@daffl
Copy link
Contributor

daffl commented Jul 17, 2013

I think that makes total sense. Lets get it into 1.1.7. Does this need a test?

@daffl daffl closed this in 8db2da5 Jul 19, 2013
@bmomberger-reciprocity
Copy link
Contributor

👍 thanks for constructing the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants