Fixed the pushstate #652 test to ensure that it should pass in all libraries and phantomjs #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link wasn’t properly checking ev.isDefaultPrevented()
|
Would it be possible to squash these into one so that I could see how you solved the issue? If not, that's cool |
Caused issues with YUI in Firefox
|
@stevenvachon If you click the Files Changed tab, it'll give you a diff that summarizes the entire pull request. (and then click View if you want to see the full file) Also, the issue may or not be solved, we're doing cross browser and cross library testing and stuff keeps popping up. :) |
|
Oh cool! I had no idea about that. Writing this test was pretty difficult and time consuming for me and I even did cross-library tests (grunt test) which passed. I didn't test any non-webkit browsers, though. Fixing the bug was actually easier than writing the unit test, heheh |
daffl
added a commit
that referenced
this pull request
Jan 29, 2014
Fixed the pushstate #652 test to ensure that it should pass in all libraries and phantomjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test used to have timing issues but has had a lot of cross-browser and cross-library issues.