-
Notifications
You must be signed in to change notification settings - Fork 3
Bitops conditional helm #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
karamveer28
commented
Feb 21, 2024
- Added boolean inputs in action to install charts in eks: "grafana_enable", "prometheus_enable", "loki_enable", "nginx_enable".
- Added defaults charts in this repo so even if user doesn't add these charts in deployment repo they will have charts ready. values can be merged from values configuration in deployment repo using BitOps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would love any input from @mcascone, specially for the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly just typos/structure. There is a change from false
to true
in the bitops config, how risky is that?
How often do you foresee having to bump versions or any other metadata in the 3rd-party charts? Is there a way to make that frictionless?
aws_eks_environment: qa | ||
aws_eks_stackname: qa-stack | ||
aws_eks_cluster_version: 1.25 | ||
aws_eks_cluster_version: 1.29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match line 4: v1.28 != v1.29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional. Just to show you can set this up to the current latest.