Skip to content

Conversation

karamveer28
Copy link
Contributor

  • Added boolean inputs in action to install charts in eks: "grafana_enable", "prometheus_enable", "loki_enable", "nginx_enable".
  • Added defaults charts in this repo so even if user doesn't add these charts in deployment repo they will have charts ready. values can be merged from values configuration in deployment repo using BitOps.

Copy link
Contributor

@LeoDiazL LeoDiazL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would love any input from @mcascone, specially for the README.

Copy link

@mcascone mcascone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just typos/structure. There is a change from false to true in the bitops config, how risky is that?

How often do you foresee having to bump versions or any other metadata in the 3rd-party charts? Is there a way to make that frictionless?

aws_eks_environment: qa
aws_eks_stackname: qa-stack
aws_eks_cluster_version: 1.25
aws_eks_cluster_version: 1.29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match line 4: v1.28 != v1.29

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional. Just to show you can set this up to the current latest.

@LeoDiazL LeoDiazL merged commit 4d357bb into main Feb 26, 2024
@LeoDiazL LeoDiazL deleted the bitops-conditional-helm branch February 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants