Adding shadow DOM support. #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
| * @param {Object} options - Optional parameters | ||
| * @param {String?} options.shadow - Use shadow DOM rather than light DOM. | ||
| */ | ||
| export default function(ReactComponent, React, ReactDOM, options= {}) { |
There was a problem hiding this comment.
Is options = {} valid in every browser that supports Proxy? If not, we might need to write this out "old school". I don't think we are currently transpiling this file.
There was a problem hiding this comment.
Yes.
The only known* difference according to caniuse is Edge 12 and 13 supporting default function parameters and not supporting Proxy.
https://caniuse.com/mdn-javascript_functions_default_parameters
https://caniuse.com/proxy
| * (some browsers are listed in the source docs with unknown feature sets)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding shadow DOM option.
optionsparameter to allow for further enhancementsoptions.shadowoption, which creating and attaches shadow DOM, rather than light DOM