Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

better messages in .sign(). updates bundle #250

Closed
wants to merge 6 commits into from
Closed

better messages in .sign(). updates bundle #250

wants to merge 6 commits into from

Conversation

matiu
Copy link
Collaborator

@matiu matiu commented Apr 30, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.678% when pulling 5b64d9a on matiu:messages-in-sign into 1de97bb on bitpay:master.

@coveralls
Copy link

coveralls commented Apr 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 94.649% when pulling ccac61e on matiu:messages-in-sign into 1de97bb on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 94.649% when pulling f1cc018 on matiu:messages-in-sign into 1de97bb on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 94.646% when pulling 11d5352 on matiu:messages-in-sign into 1de97bb on bitpay:master.

@coveralls
Copy link

coveralls commented May 1, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.006%) to 94.646% when pulling 959aff8 on matiu:messages-in-sign into 1de97bb on bitpay:master.

@matiu
Copy link
Collaborator Author

matiu commented May 3, 2016

updated

@coveralls
Copy link

coveralls commented May 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.006%) to 94.676% when pulling cbd0570 on matiu:messages-in-sign into c0e5579 on bitpay:master.

@coveralls
Copy link

coveralls commented May 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.006%) to 94.676% when pulling cbd0570 on matiu:messages-in-sign into c0e5579 on bitpay:master.

Alfonso69
Alfonso69 reviewed Jul 17, 2016
View reviewed changes
bitcore-wallet-client.js
@@ -814,12 +814,35 @@ API.getRawTx = function(txp) {
return t.uncheckedSerialize();
};

API.signTxp = function(txp, derivedXPrivKey) {
API.signTxp = function(txp, xpriv) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private key

@matiu matiu closed this Aug 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matiu @coveralls @Alfonso69