Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cacheInput related function in Transaction.js #158

Closed
matiu opened this issue Mar 15, 2014 · 4 comments
Closed

Remove cacheInput related function in Transaction.js #158

matiu opened this issue Mar 15, 2014 · 4 comments

Comments

@matiu
Copy link
Contributor

matiu commented Mar 15, 2014

cacheInput related functions doesnt seem to be used anywhere, and they have no test. We should remove them to improve code quality and to not confuse new developers.

@matiu
Copy link
Contributor Author

matiu commented Mar 15, 2014

Note this:

#80

as evidence that it is confusing

@maraoz
Copy link
Contributor

maraoz commented Mar 25, 2014

Agreed. Transaction.js needs a huge refactor. We might need separate files with helper classes (e.g. TransactionIn, TransactionOut, TransactionBuilder, maybe TransactionSigner)

@matiu
Copy link
Contributor Author

matiu commented Mar 25, 2014

Maybe we can start by removing legacy code, without breaking backwards compatibility.

@ryanxcharles
Copy link
Contributor

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants