lazy calc for xpubkey in HDPrivateKey #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, but is the test specific enough? Maybe it would be better to check for the internal property... (for starters, the test would pass before this PR as well). |
| @@ -76,6 +76,11 @@ describe('BIP32 compliance', function() { | |||
| publicKey.toString().should.equal(publicKey.xpubkey); | |||
| }); | |||
|
|
|||
| it('cache for xpubkey works for test vector 1', function() { | |||
| var pk = HDPrivateKey(vector1_m_private); | |||
| pk.xpubkey.should.equal(pk.xpubkey); | |||
There was a problem hiding this comment.
Add this line before please: expect(pk._hdPublicKey).to.be.undefined; so this test fails before the commit
eordano
added a commit
that referenced
this pull request
Mar 20, 2015
lazy calc for xpubkey in HDPrivateKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1147