Changes behavior of toJSON to work as expected with JSON.stringify
#1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
- see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON%28%29_behavior - Updates CONTRIBUTING with changes to Stardard Methods - Aliases toJSON for toObject - Removes all `fromJSON` methods, and many cases replaces with `fromObject` - Constructors expect an object parsed via `JSON.parse` for JSON input
braydonf
force-pushed
the
standardizetojson
branch
from
3443591
to
a50fcce
Compare
|
Rebased on master |
pnagurny
added a commit
that referenced
this pull request
Aug 14, 2015
Changes behavior of `toJSON` to work as expected with `JSON.stringify`
|
What's the reason for removing fromJSON as well? The Mozilla page doesn't mention it so I see no reason not to leave it for convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fromJSONmethods, and many cases replaces withfromObjectJSON.parsefor JSON inputJSON.stringify()standardizetoJSON()andtoObject()#1307