Feature/sin02 #448
Merged
Feature/sin02 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matiu
commented
Jul 23, 2014
matiu
commented
- adds #fromPubKey constructor for SIN
|
You may also want to throw an exception in the constructor when you try to create a SIN with an invalid data length (it should be 20 bytes), which should catch errors where people try to create one with a public key. See the Address constructor, which does that. Also, please don't commit the bundle in future PRs. The bundle should only be committed for version tags, and it should be the main, minified bundle, not the development bundle. |
Merged
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
Add log level debug on push notifications service
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
Feature/sin02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.