Modify Transaction Interface #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add checks when serializing * Add default _estimateSize to generic inputs * Fix multisig size estimation * Change _addOutput to addOutput * Add addInput and using that internally * Split `getFee` out from `_updateChangeOutput`
| try { | ||
| this.toBufferWriter(bufferWriter); | ||
| } catch (e) { | ||
| console.log(this); |
There was a problem hiding this comment.
did you leave this on purpose? why not throw an exception?
|
could you rewrite this test to use the new interface? |
eordano
force-pushed
the
feature/safeSerialize
branch
from
50503c7
to
9a73338
Compare
* For internal usage: for example, testing Script.Interpreter
|
Added them! |
|
ACK |
micahriggan
pushed a commit
to micahriggan/bitcore
that referenced
this pull request
Dec 27, 2018
update socket-io / preconditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #789 and #799
getFeeout from_updateChangeOutput