-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#introduction to css #239
base: #Introduction_to_CSS
Are you sure you want to change the base?
#introduction to css #239
Conversation
Hi @ManasiAbh, you uploaded your blog as a PDF. We can't comment/review those on GitHub. Would you mind removing that and uploading your MD file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your blog is very similar to @eden-bouskila 's. Are you collaborating on the same blog? If so, then everything looks good so far! The only critique I have is this:
The screenshots of the code look kinda ugly and out of place. I think it's better if you just take the code and include it in your blog using the MD code block tags. See @emily-gui 's blog as she did this. Not only does it make everything look more professional, but it also allows readers of your blog to copy and paste your code snippets and test them out immediately rather than type everything out themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now! Great job with your blog!
|
||
This looks like a huge chunk of code right now, but let’s break it down! | ||
|
||
HTML works as the canvas for all of our objects, so for every object in our city, we create a div class for it. Once we do that, we can edit those divs using our CSS, which is like our paint! It allows us to control how the objects appear on the site, like color, layout, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a sentence here to further explain the analogy between HTML/CSS and canvas/paint; feel free to change or edit to make it more technically accurate!
@@ -0,0 +1,224 @@ | |||
## Building a Mini City: HTML and CSS Portion | |||
## Purpose | |||
HTML and CSS are extremely important parts of learning about how websites work. Every website uses HTML to display content such as text or images. Being able to grasp a few concepts of HTML and CSS can help a lot when it comes to learning more intricate subjects in computer science, so it's important to get some experience with it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you explain HTML in the intro for beginners. It would be helpful to also include a sentence about what CSS here, especially because the blog post is about both HTML and CSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, for the last sentence could use a different word choice instead of "important" to avoid redundancy. Maybe "crucial"/"critical"/"valuable"
|
||
Got it? Great! | ||
|
||
Next, we have to actually create our HTML tag. Tags are essentially commands that tell our editor what type of HTML we are writing. This just means that we are beginning to write our HTML code, but first we must actually tell our computer that we will be writing in HTML. To do this, simply type <html> on your second line. Your code should look like this so far: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with introducing key coding terms and explaining them simply/clearly!
|
||
Now that we have established the fact that we will be writing in HTML, it’s time to get into the fun stuff. We start by writing <head> in our third line of code. This tells our editor that the information for our header will be stored here. | ||
|
||
After we write our <head> tag, we know that we should give our project a title. Let’s title our project “My Mini City.” This is how your code should look now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, usually punctuation goes inside quotation marks. Such as "My Mini City." or "My Mini City," and...
We will be writing all of our CSS in the head portion of our code. | ||
|
||
To style our webpage, we will need to learn the CSS syntax. A CSS rule-set consists of a selector and a declaration block. | ||
<img src=https://lh3.googleusercontent.com/3UcaVdjNU8MuMn4Feims4asq1epCgIOEwJX2goOH8SZE2eP2IKz5vRvCuSL9howvCc_Co_G2TE8Tqe5pIPgTAITV9KB28hqPEWXLzvZZ7xTnF1GNBohcY75WK00KBHIfbJ4nufVR> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could add a sentence or two (or maybe even revise the sentences you already have) to reference/explain this useful image a bit more to the audience, I think that would help them better understand the CSS rule-set
* rotate(): This transformation rotates an element clockwise or counter-clockwise according to a given degree. For example, | ||
transform: rotate(20deg). | ||
* skew(): Unlike rotate, this transformation skews an element along the X and Y-axis by the given angles. For example, this example skews the element 30 degrees along the X-axis and 50 degrees along the Y-axis. | ||
transform: skew(30deg, 50deg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this segment "transform: skew (30deg, 50 deg);" meant to be an example and part of the skew bullet point? If so, I would follow how the rotate bullet point is written to make it clearer for the audience.
2. Display: This property affects whether or not an element is shown. If you choose display: none, then the element will not be visible. | ||
3. Background-color: It determines the background color of the element. A color can be specified by a valid color name (“black”), a hexadecimal value (like “ffffff”), or an rgb value (“rgb(255,0,0)”). | ||
4. Height and Width: These properties are used to set the height and width of the element. | ||
5. Transform: This property is used to make 2D transformations. The most commonly used transformations are rotate() and skew. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does rotate need to have () after it? If not, I would eliminate them. (Also, this goes for the two bullet points below, with rotate and skew too).
``` | ||
|
||
|
||
Now that you’ve laid down the foundation and built a road, you can start building more roads, bridges, buildings, or anything else you might want in your mini city! This is what our city looked like after creating all the code described in this tutorial: <img src=https://lh4.googleusercontent.com/yu268ztRROLzh3AjLVUeNroSMUlbOsHpZzsWNIokeRtjF7iz-1mqWCqJPdtL1-JyUX6shb3kq28_CYm1xihsf70nPM8EBfHVERg13x7ef5nf5TibItYGI7ixBu_CHcgyIUfRML_c> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would add a sentence or two more here, wrapping up about the importance of HTML/CSS to better mirror your introduction.
Reference to issue
Description of the changes proposed in the pull request
Link to Code SandBox
Link to Loom video (if blog/workshop completed)
Reviewers requested: