build fixes #188
Closed
build fixes #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bitsharesjs reference
abitmore
reviewed
Aug 30, 2022
abitmore
reviewed
Aug 30, 2022
| max_jobs: 3 | ||
| platform: | ||
| - x64 | ||
| environment: | ||
| nodejs_version: 12 | ||
| nodejs_version: 16 | ||
| GITHUB_TOKEN: | ||
| secure: jr08/oNuLLnJAth0P0/KslT6bJPfGGA/QkkPWo83z82i0R+U6jJMZxWVrqDBMXKL | ||
| cache: |
There was a problem hiding this comment.
I guess the permission issue Appveyor reports (EPERM: operation not permitted, unlink) can be solved by not caching the node modules?
phoenixframework/phoenix#2464 -> lint-staged/lint-staged#274 -> lint-staged/lint-staged#289
There was a problem hiding this comment.
Doing so made some progress, now failing to minify bitsharesjs (develop branch):
$ cross-env NODE_ENV=production minify build/bitsharesjs.js --mangle --outFile build/bitsharesjs.min.js
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module './_baseGetTag'
Require stack:
The EPERM error still ocurrs, however appveyor passes by it now treating it as a warning.
There was a problem hiding this comment.
yarn run dist works in my beet dev environment, so it's something environmental in appveyor
|
Relevant for github action: https://github.com/marketplace/actions/electron-builder-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bitsharesjs reference