Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New upload json feature, fixes & optimizations #247

Merged
merged 20 commits into from
Aug 29, 2023
Merged

New upload json feature, fixes & optimizations #247

merged 20 commits into from
Aug 29, 2023

Conversation

grctest
Copy link
Contributor

@grctest grctest commented May 30, 2023 •
edited
Loading

Implement new upload JSON feature to address #246

Introduced a fix for TUSC: #248

Introduces optimized account/asset lookup for all BTS operations: #249

Fix balances rendering properly: #255

Localizes the contents of BTS blockchain based injected operation prompts: #252

Resolves #256

@grctest
New upload json feature
f902f63 
Implement new upload JSON feature
@grctest
Update local.vue
7ea3509 
Fix locale key
@grctest
Update config.js
a1ba8d1 
Add nodes
@grctest
TUSC Fix
aee0aa2 
Fixes issue 248
@grctest
Introduced batched blockchain queries
6b0df81 
Add lodash package for key checks
Fetch accounts and assets found in prompt operations in batches.
@grctest grctest mentioned this pull request Jun 7, 2023
Closed
@grctest grctest changed the title New upload json feature New upload json feature, fixes & optimizations Jun 9, 2023
@grctest
Update BitShares.js
85422a7 
Optimize Bitshares prompts
@grctest
bug fixes
92373ff 
Fix  issue bitshares#255
Enable sorting balance table
Increased height of the balance table
Fixed menu icon rendering
@grctest grctest mentioned this pull request Jun 26, 2023
Closed
@grctest
Update balances.vue
0ad3930
@grctest
Translate prompt contents
3973f18 
Translate the contents of prompts
Change prompt UX to card, instead of text rows.
Increased size of prompt window.
@grctest
Copy link
Contributor Author

grctest commented Jun 30, 2023 •
edited
Loading

Localization needs further work, it seems the machine translations translated the variables, resulting in missing fields when switching between languages.

Edit: Resolved!

@grctest grctest mentioned this pull request Jun 30, 2023
Closed
@grctest
Prompt UX
5647f84 
per operation JSON modals
Prompt can now scroll
Simple prompt summary added
@grctest
Fix locales
cacd633 
Fix locales with broken variable script
This was referenced Jul 5, 2023
Closed
Closed
@grctest
Replace lodash
dccae9f 
Replacing get and chunk functions
@grctest
UX improvements and bug fixes
424d48d 
UX improvements to the injected call popup prompt
Move approve/reject buttons to below ui card in prompt preview
Account for testnet batch size limits
@grctest
Request checks
7b3982e 
Basic check on the format of the incoming request
@grctest
Bug fixes & translations
6342c9d 
Fix settingsRow error
Additional error checking
Remove "Scan QR" button until issue bitshares#256 is resolved
Prevent qrTX disrupting the ipcRenderer popup creation process
Translate the permission prompt
@grctest
Update qr.vue
acc50f6 
Remove button temporarily
@grctest grctest mentioned this pull request Jul 5, 2023
Closed
@grctest
Replace qrcode package
6afe935 
Replacing qrcode-reader-vue3 for vue-qrcode-reader package now that it supports vue3, resolving bitshares#256
@grctest grctest mentioned this pull request Jul 8, 2023
Closed
@sschiessl-bcp
Copy link
Collaborator

this has conflicts?

@grctest
Copy link
Contributor Author

grctest commented Jul 15, 2023

this has conflicts?

It seems to only be the package lock file which is conflicting?

The package file was updated, I tried deleting the lock file but appveyor hasn't resolved the conflict despite the file no longer existing.

The package json file has been updated to use the new QR code package

@grctest
Copy link
Contributor Author

grctest commented Jul 15, 2023

What do you think of the new operation viewer & paginator component?

My only reservation with it is that in its current format that a 3rd party app could sneak in an operation and the user doesn't check it, if there's several thousand operations in the prompt.

What do you think about separate paginating operation components for different operation types? That way all the transfers would be grouped together, and any non-transfers would be visible below the transfers for example? It might be a bit of a cluttered edge case to resolve

@sschiessl-bcp
Copy link
Collaborator

What do you think of the new operation viewer & paginator component?

My only reservation with it is that in its current format that a 3rd party app could sneak in an operation and the user doesn't check it, if there's several thousand operations in the prompt.

What do you think about separate paginating operation components for different operation types? That way all the transfers would be grouped together, and any non-transfers would be visible below the transfers for example? It might be a bit of a cluttered edge case to resolve

Any user that executes thousands operations is probably a power user, and will not need special considerations and protection

@grctest
Copy link
Contributor Author

grctest commented Aug 2, 2023

Cool, in that case I feel that both #247 and #257 are ready for merge :)

Any other change requests?

@sschiessl-bcp sschiessl-bcp merged commit 62330b6 into bitshares:develop Aug 29, 2023
@sschiessl-bcp sschiessl-bcp mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschiessl-bcp sschiessl-bcp sschiessl-bcp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grctest @sschiessl-bcp