Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Change replay percentage to total block size processed #1289
CORE TEAM TASK LIST
I believe using the file size of the block log is an inaccurate measure of the total block size to apply. The reason is that the block log is only ever appended to. For example, when switching between forks, the blocks that are re-applied will be appended to the block log again. Similarly, the last 50 blocks of a replay are appended again.
I believe the error is small for a typical node, but can be significant for a node that is restarted often.
This doesn't sound ideal.
I guess it won't be too significant, since we don't reapply too old blocks anyway. IMHO, even it's not accurate, it's still better for estimation than block counts.
referenced this issue
Sep 19, 2018
I understand this is a closed Issue, so perhaps I need to open a separate one. I feel the output could be improved. Currently is looks like this:
Is it trivial to make it look something like:
Round to two decimal places and convert to K, M, G notation.