Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement update_authorities command in CLI #1080

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

oxarbitrage
Copy link
Member

replacement for #270

more discussion at #163

needs:

  • protection for cycles. what condition(s) to protect exactly.
  • more tests cases.

i tried different implementations however this format and execution was the in the direction of keeping the function action clear, small and clean.(probably possible to do it smaller).

adding a key to active.
update_authorities alpha [] [1, [["BTS6kFiqv1kpMHM2tMAcHArkDNZHCi1SiT2iQ9sC2U4SnVWGM1Y9t", 1]]] "" true

deleting the key:
update_authorities alpha [] [1, [["BTS6kFiqv1kpMHM2tMAcHArkDNZHCi1SiT2iQ9sC2U4SnVWGM1Y9t", 0]]] "" true

add account:

update_authorities alpha [] [1, [["1.2.0", 0]]] "" true

etc, more samples in the test cases.

@jmjatlanta
Copy link
Contributor

Is there a possible test case here: #269 (comment)

I think that comment in the link above means the protection logic should be on the cli wallet side. While I'm not totally up to speed on owner/active permissions, a test case could demonstrate that a client can protect their users from locking themselves out. I'm not sure if that is within the scope of this issue, though.

@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 21, 2018
@ryanRfox
Copy link
Contributor

ryanRfox commented Jan 3, 2019

May I request an update on the status of this PR and #163? I see these listed as In Progress on the Project CLI Account Update Commands. I'd like to close that Project in favor of moving the Issues and PR to the Project Backlog or Feature Release.

@abitmore abitmore changed the title implement update_authorities implement update_authorities command in CLI Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Project Backlog
  
New -Awaiting Core Team Evaluation
Development

Successfully merging this pull request may close these issues.

None yet

4 participants