Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive account permissions #269

Open
testzcrypto opened this issue May 1, 2017 · 27 comments
Open

Fix recursive account permissions #269

testzcrypto opened this issue May 1, 2017 · 27 comments

Comments

@testzcrypto
Copy link

BitShares allow to change permissions of account A to account A.
More info can be found here: https://steemit.com/blockchain/@hipster/sad-story-how-i-lost-bitshares-account

@abitmore
Copy link
Member

abitmore commented May 2, 2017

IMHO we can arrange a hard fork to fix this account (and perhaps other similar accounts).

It's said in https://bitshares.org/technology/dynamic-account-permissions/ :

In practice client software can detect cycles and prevent them from being formed.

So it's designed that client software should take care of the permissions.

Setting the owner permission to an account itself is legit, with this approach a group with active permission can sign transactions/operations that require owner permission. And vise versa.

@dnotestein
Copy link

dnotestein commented May 2, 2017

if we're going to do a social fix of this sort (I'm not opposed), should we consider also returning funds stuck in the poloniex phishing account to their original senders?

https://bitshares.openledger.info/account/poloniex/overview

@TheTaconator
Copy link
Contributor

On fixing specific accounts, I am worried about the precedent that it would set. At a minimum, I think that any advocate should bring this up for discussion with the community.

@pmconrad
Copy link
Contributor

pmconrad commented May 3, 2017

Developers should never touch individual accounts. We are not judges and cannot decide which accounts or transactions may be legit or not.
The community cannot decide that either. (They are probably even worse judges than the devs.)

@dnotestein
Copy link

@pmconrad Of course the community can decide such an issue. It's fundamental to any consensual blockchain system that the users can make such a decision by electing to run a new version of the software with new rules. There's no limitation on what those new rules are. The guys that don't grasp this have never really understood the basic nature of how users self-select to make themselves part of a blockchain community. Naturally, such changes can lead to community splits (e.g. ETH and ETC). But to say a community can't decide to do such things is just flat out wrong. And to say they are probably worse judges, well, that's just your opinion of the community.

@oxarbitrage oxarbitrage modified the milestones: Roadmap to hardfork, Hardfork - Locked accounts - assets, Roadmap to hardfork 1, Hardfork - Operations and Authority related., Hardfork - Authorities/Sign Issues Aug 13, 2017
@bycz6
Copy link

bycz6 commented Nov 22, 2017

It happen with me the same!
user: bycz2

@abitmore abitmore modified the milestones: Hardfork - Operations and Authority related., Future Consensus-Changing Release Nov 28, 2017
@bycz6
Copy link

bycz6 commented Dec 5, 2017

If I hash the brain key I get the priv key right?

@abitmore
Copy link
Member

abitmore commented Dec 5, 2017

@bycz6 when the account is locked, brain key won't work. Save your private keys and brain key (if you have) safely, I think we will fix it some time in the future (may be long, so be patient).

@xeroc
Copy link
Member

xeroc commented Dec 6, 2017

@bycz6 a sequence number needs to be appended to the brainkey to get to a private key.
Do not mix brain key with account/password

@bycz6
Copy link

bycz6 commented Dec 6, 2017

Thanks for the feedback @xeroc @abitmore

@bycz6
Copy link

bycz6 commented Jan 3, 2018

EOSIO/eos#922
This could also apply, right?

@dayman32
Copy link

dayman32 commented May 30, 2018

Similar problem. I have keys. Changed the threshold weight to 2. And I have 1. All access denied. When will the bug be resolved? Has passed 1 year-I look no one rushing. Dozens of people with a similar problem!
722525f555

@clockworkgr
Copy link
Member

Well , it's not really a bug. As @abitmore described, there is a legit reason for allowing it as far as the chain is concerned.

As mentioned above, it's a client software issue to ensure that "incompatible" permissions are not set.

This is more like going out and leaving your house-keys inside the house. Doesn't mean your door is buggy.

@dayman32
Copy link

dayman32 commented Jun 2, 2018

When should we wait for a decision or correction? A lot of investors in this situation.

@bycz6
Copy link

bycz6 commented Jun 4, 2018 via email

@pmconrad
Copy link
Contributor

pmconrad commented Jun 5, 2018

As these accounts cannot be unlocked without a hardfork, and a hardfork cannot be done without a BSIP, I'd suggest to close this issue. This needs to be discussed in a different place.

@bycz6
Copy link

bycz6 commented Jun 5, 2018 via email

@abitmore
Copy link
Member

abitmore commented Jun 5, 2018

@dayman32
Copy link

dayman32 commented Aug 9, 2018

Is there news? Is there a hard fork planned or another solution to the problem? Dates, dates?!

@pmconrad
Copy link
Contributor

pmconrad commented Aug 9, 2018

No.

@abitmore
Copy link
Member

abitmore commented Aug 9, 2018

New locked account: https://cryptofresh.com/u/1.2.907383

@abitmore
Copy link
Member

abitmore commented Aug 9, 2018

Created issue in BSIP repository: bitshares/bsips#94. Closing this one.

@abitmore abitmore closed this as completed Aug 9, 2018
@abitmore abitmore removed this from the Future Consensus-Changing Release milestone Aug 9, 2018
@abitmore abitmore reopened this Oct 14, 2018
@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Oct 14, 2018
@ryanRfox ryanRfox added this to To Do in Protocol Upgrade Release (3.0.0) via automation Feb 1, 2019
@ryanRfox ryanRfox removed this from New -Awaiting Core Team Evaluation in Project Backlog Feb 1, 2019
@ryanRfox ryanRfox added this to To do in Protocol Upgrade Release (4.0.0) via automation Feb 1, 2019
@ryanRfox ryanRfox moved this from To do to In development in Protocol Upgrade Release (4.0.0) Feb 19, 2019
@ryanRfox ryanRfox removed this from In development in Protocol Upgrade Release (4.0.0) Oct 17, 2019
@abitmore abitmore added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Feb 2, 2020
@dayman32
Copy link

dayman32 commented Apr 2, 2020

For 4 years I have been observing how the solution of this issue is transferred from year to year. Her in general, will someone ever decide?

People just want to withdraw their money from these blocked accounts.

@dayman32
Copy link

dayman32 commented Apr 2, 2020

Please put a solution to this issue for at least 2020. To put off the problem for 5 years is not very serious. Please, if you need sponsorship or help create a topic, many have lost huge amounts on this issue.

@iceworlder
Copy link

Please put a solution to this issue for at least 2020. To put off the problem for 5 years is not very serious. Please, if you need sponsorship or help create a topic, many have lost huge amounts on this issue.

now 6 years.

@bycz6
Copy link

bycz6 commented Jan 25, 2021 via email

@abitmore
Copy link
Member

abitmore commented Jan 25, 2021

What users in this situation can do at this moment:

  • Keep your old keys, backups and passwords safe, since they might be needed to recover your funds in the future. If you've lost the keys nobody can help.
  • For assets which is not BTS, please ask the asset owners for potential help (E.G. transfer out funds via override_transfer_operation).
  • If you are able to code a fix, or find someone to code a fix, or coordinate somehow to code a fix, please feel free to do it and create a pull request.
  • Wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Project Backlog
  
New -Awaiting Core Team Evaluation
Development

No branches or pull requests