New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #944 unexpected "Missing Active Authority" message for update_asset_issuer #1255

Merged
merged 4 commits into from Aug 16, 2018

Conversation

Projects
3 participants
@abitmore
Member

abitmore commented Aug 14, 2018

PR for #944.

This should not break anything. To be safe, sync the chain with --force-validate option.

./witness_node --force-validate

abitmore added some commits Aug 14, 2018

Added test case to reproduce #944
tx_missing_active_auth exception is thrown when owner authority is missing

@abitmore abitmore added this to In progress in Feature release (201810) via automation Aug 14, 2018

// https://github.com/bitshares/bitshares-core/issues/944
GRAPHENE_REQUIRE_THROW( tx.verify_authority( db.get_chain_id(), get_active, get_owner ),
graphene::chain::tx_missing_owner_auth );

This comment has been minimized.

@pmconrad

pmconrad Aug 16, 2018

Please add signature from alice_active and verify that it still complains about missing owner, then replace with signature from alice_owner a verify that is doesn't throw anymore.

@pmconrad

Looks good, thanks!

Feature release (201810) automation moved this from In progress to In Testing Aug 16, 2018

@abitmore abitmore merged commit 717eb85 into develop Aug 16, 2018

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Feature release (201810) automation moved this from In Testing to Done Aug 16, 2018

@jmjatlanta

This comment has been minimized.

jmjatlanta commented on tests/tests/authority_tests.cpp in fbef6c2 Aug 17, 2018

I do not see how this situation is different than line 1521. One is expecting a throw and the other is not. How would both of these pass?

This comment has been minimized.

jmjatlanta replied Aug 17, 2018

I see now. The code is clear (transaction requirements are different), I was not.

@abitmore abitmore deleted the 944-missing-owner-auth branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment