Fix #944 unexpected "Missing Active Authority" message for update_asset_issuer #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tx_missing_active_auth exception is thrown when owner authority is missing
pmconrad
reviewed
Aug 16, 2018
tests/tests/authority_tests.cpp
Outdated
| // https://github.com/bitshares/bitshares-core/issues/944 | ||
| GRAPHENE_REQUIRE_THROW( tx.verify_authority( db.get_chain_id(), get_active, get_owner ), | ||
| graphene::chain::tx_missing_owner_auth ); | ||
|
|
There was a problem hiding this comment.
Please add signature from alice_active and verify that it still complains about missing owner, then replace with signature from alice_owner a verify that is doesn't throw anymore.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #944.
This should not break anything. To be safe, sync the chain with
--force-validateoption.