Updating methods getTicker and getAvailableBooks to use signed request #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocordz
force-pushed
the
feature/autenticate-requests
branch
from
677d8be
to
92dba02
Compare
viccomx
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Code LGTM but feels like it wont help for what you need to achieve as ticker is not a PHP endpoint, it is a JAVA endpoint.
This makes me wonder if it has the rate limit restriction, if it doesn't then this should be more than enough.
To check if ticker has the restriction check engine_orders service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new methods similar to getTicker and getAvaliableBooks, but using signed requests