Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enable browser integration" should be grayed out when using Linux #2556

Closed
bramirezMAP opened this issue May 4, 2022 · 2 comments · Fixed by #2754
Closed

"Enable browser integration" should be grayed out when using Linux #2556

bramirezMAP opened this issue May 4, 2022 · 2 comments · Fixed by #2754
Labels
bug desktop Desktop Application

Comments

@bramirezMAP
Copy link

bramirezMAP commented May 4, 2022

Steps To Reproduce

  1. On the desktop app, go to File > Settings > App Settings (All Accounts) and ensure that Enable browser integration is enabled.
  2. Open the extension and go to Settings > Security.
  3. Try to check Unlock with biometrics.

Expected Result

One of the two:

  • Browser integration works successfully
  • I should not have been allowed to enable browser integration in step 1 because it is not supported on the platform; the option should be grayed out.

Actual Result

An error appears that says "Browser integration is not enabled" is displayed even though browser integration was marked as enabled in desktop, because biometrics is not supported and thus the desktop app does not actually enable integration.

Screenshots or Videos

No response

Additional Context

Web extension info:

  • Build: 1.58.0
  • Browser: Firefox 99.0.1

See bitwarden/desktop#1132 - @eliykat had suggested creating a new issue to track disabling this item in the UI but seems that it was never created.

Operating System

Linux

Operating System Version

Ubuntu 22.04 LTS

Installation method

Snap

Build Version

1.33.0

@bramirezMAP bramirezMAP added the bug label May 4, 2022
@Hinton Hinton added the desktop Desktop Application label May 5, 2022
@Hinton Hinton transferred this issue from bitwarden/desktop May 5, 2022
@LosD
Copy link

LosD commented Jun 19, 2023

This is not complete. An error message is not the same. Especially when it looks like this:
image

@djsmith85
Copy link
Contributor

@LosD The error message being displayed like that, is unrelated to this issue.
It's more likely related to #2628

Kind regards,
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug desktop Desktop Application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants