[PM-5189] Fix issues with inline menu rendering in iframes and SPA websites #8431

cagonzalezcs · 2024-03-21T18:21:39Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-5189
https://bitwarden.atlassian.net/browse/PM-5508
https://bitwarden.atlassian.net/browse/PM-6748
https://bitwarden.atlassian.net/browse/PM-6200

📔 Objective

This set of changes effectively represents a complete re-architecture of how we inject the inline menu into a user's page. This approach now injects the inline menu at the top level of a page exclusively, handling interactions with nested iframe forms through messaging.

This also introduces a messaging layer between the content script behavior present on a page, and the inline menu UI elements that exist on the page. This additional messaging layer allows us to communicate between the extension background, the content script on the page, and the inline menu ui elements without depending on window message listeners that postMessages to the content script. This ensures that messages coming from the inline menu are hidden from the tab where the inline menu is injected.

Other fixes are introduced into this task that improve performance and consistency of the inline menu injection process.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-04-08T20:20:05Z

Codecov Report

Attention: Patch coverage is 90.71654% with 206 lines in your changes missing coverage. Please review.

Project coverage is 31.70%. Comparing base (974162b) to head (564f1c5).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ces/autofill-overlay-content.service.deprecated.ts	90.85%	20 Missing and 13 partials ⚠️
...wser/src/autofill/background/overlay.background.ts	92.91%	3 Missing and 24 partials ⚠️
...ecated/background/overlay.background.deprecated.ts	90.58%	7 Missing and 17 partials ⚠️
...nline-menu/pages/list/autofill-inline-menu-list.ts	93.97%	2 Missing and 13 partials ⚠️
...ofill/services/autofill-overlay-content.service.ts	94.69%	2 Missing and 10 partials ⚠️
apps/browser/src/background/main.background.ts	0.00%	12 Missing ⚠️
...ame-content/autofill-inline-menu-iframe.service.ts	93.82%	4 Missing and 6 partials ⚠️
...cated/content/bootstrap-legacy-autofill-overlay.ts	0.00%	9 Missing ⚠️
...src/autofill/content/bootstrap-autofill-overlay.ts	0.00%	8 Missing ⚠️
...nu/content/autofill-inline-menu-content.service.ts	94.07%	0 Missing and 8 partials ⚠️
... and 15 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8431      +/-   ##
==========================================
+ Coverage   30.36%   31.70%   +1.34%     
==========================================
  Files        2594     2610      +16     
  Lines       76014    77705    +1691     
  Branches    14229    14583     +354     
==========================================
+ Hits        23082    24637    +1555     
- Misses      51149    51206      +57     
- Partials     1783     1862      +79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tionService

…input-fields-that-do-not-relate-to-user-login

…ect-into-sub-frames-on-install

…ework of tests

…input-fields-that-do-not-relate-to-user-login

…ect-into-sub-frames-on-install

…b-frames-on-install' into autofill/pm-5189-fix-issues-present-with-inline-menu-rendering-in-iframes

…ting reference to auth status to use observable

…d is populated

…input-fields-that-do-not-relate-to-user-login