[PM-6696] Collections not loading when adding item

[gbubemismith]

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Currently, when creating an item under an organization, collections are not loaded, and because of this, the item cannot be saved. The objective of this ticket is to ensure collections load when displaying the form when adding a new item.

Code changes

The collections were loaded in ngOnInit, which is not executed until after the first ngOnChanges call. As a result, when ngOnChanges needed the collections immediately (such as when adding a new item), they were unavailable.

To fix this bug, I ensure collections are always loaded before they are needed.

Screenshots

Screen.Recording.2024-04-11.at.11.58.51.AM.mov

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 27.20%. Comparing base (9b022d2) to head (fe7e011).

Files	Patch %	Lines
.../desktop/src/vault/app/vault/add-edit.component.ts	0.00%	1 Missing ⚠️
...angular/src/vault/components/add-edit.component.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8691      +/-   ##
==========================================
- Coverage   27.20%   27.20%   -0.01%     
==========================================
  Files        2339     2339              
  Lines       68267    68268       +1     
  Branches    12749    12750       +1     
==========================================
  Hits        18570    18570              
- Misses      48301    48302       +1     
  Partials     1396     1396              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – e2b78f77-709f-4d3c-b47b-3af8e35be813

No New Or Fixed Issues Found