Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1919] - Set output for artifact build commit #276

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mimartin12
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

๐Ÿšง Type of change

  • ๐Ÿš€ New feature development
  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

With our deployments today, we simply output the commit that is in the branch used as the source of the workflow trigger. This doesn't allow us to accurately show which commit is actually deployed, especially in monorepos. This extends this artifact action to set an additional output, artifact-build-commit: which allows other actions to use the real commit or "build commit" of the artifact.

๐Ÿ“‹ Code changes

  • download-artifacts/main.js: Set the new output to the value of artifacts.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@bitwarden-bot
Copy link

bitwarden-bot commented Apr 18, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 7a7a4d07-7ef6-4e89-b688-da6c72bd1f03

No New Or Fixed Issues Found

@mimartin12 mimartin12 force-pushed the DEVOPS-1919-set-artifacts-sha branch from 5b587aa to 34245cb Compare April 18, 2024 22:14
@mimartin12 mimartin12 merged commit c3bc6a1 into main Apr 18, 2024
5 of 6 checks passed
@mimartin12 mimartin12 deleted the DEVOPS-1919-set-artifacts-sha branch April 18, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants