This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
[bug] Ensure clients that always remember emails have an avenue to do so #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
With Account Switching we tweaked the way logic determined if an email should be remembered or not. Instead of storing a specific boolean key to know whether or not we had a remembered email on init, we just check to see if a remembered email already exists. This works well for apps like web, where remember email is also controllable with an input, but not so much for apps that always remember email like browser and desktop.
Code changes
Instead of going back to the way things were and having client specific logic in the base login component, we should ensure that we always remember emails for clients that behave that way in the clients that need to special case.
This commit exposes a component variable that can be set by clients to determine if email should always be remembered.
Before you submit
npm run lint
) (required)