-
Notifications
You must be signed in to change notification settings - Fork 20
Added not wasm config for get_ancestors #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+53
โ24
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d0eedbc
Added not wasm config for get_ancestors
jrmccannon 4cb672d
Creating a struct to wrap HashMap
jrmccannon d8dea97
Linting
jrmccannon 669639d
Fixing feature macros.
jrmccannon 65be635
Added uniffi bindings to collection_client
jrmccannon 3f9f4b2
linting
jrmccannon e1bfcdc
Merge branch 'main' into jmccannon/conditional-get-ancestors
jrmccannon 43abdd4
Merge branch 'refs/heads/main' into jmccannon/conditional-get-ancestors
jrmccannon cb3f5a4
Merge branch 'main' into jmccannon/conditional-get-ancestors
jrmccannon be918f9
Merge branch 'main' into jmccannon/conditional-get-ancestors
jrmccannon 464f697
Adding export to impl blocks
jrmccannon 8161973
Adding uniffi specific implementations for CollectionViewTree and Colโฆ
jrmccannon 1507425
linting
jrmccannon b029292
Merge branch 'main' into jmccannon/conditional-get-ancestors
jrmccannon f480f89
Have ancestor map use CollectionId
jrmccannon 789b822
rename to get_item_for_view
jrmccannon c22741e
Merge branch 'main' into jmccannon/conditional-get-ancestors
jrmccannon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
โ Are we ok with swallowing an empty or invalid
id
here? Is that the goal of this?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long term I think we would split
CollectionView
similar to folders so that ID is required, and you have a separate DTO for creating them.I wouldn't be particularly concerned about ID being
None
here.