Skip to content

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 26, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26087

📔 Objective

Sets a schedule that is. run weekly but has an early exit on uneven weeks. I think this should match the renovate cadence.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner September 26, 2025 12:59
@Hinton Hinton requested a review from coroiu September 26, 2025 12:59
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa39ce7af-507c-440f-a511-13326ea2606f

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.56%. Comparing base (9947387) to head (aa3aab6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         276      276           
  Lines       27379    27379           
=======================================
  Hits        21510    21510           
  Misses       5869     5869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton merged commit fab5553 into main Sep 29, 2025
50 checks passed
@Hinton Hinton deleted the arch/api-cron-scheduler branch September 29, 2025 08:17
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants