-
Notifications
You must be signed in to change notification settings - Fork 20
[PM-26347] Bump version to 1.85 / version 2024 #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
64f2ba8
to
1087dea
Compare
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 78.48% 78.55% +0.07%
==========================================
Files 276 276
Lines 27435 27483 +48
==========================================
+ Hits 21531 21588 +57
+ Misses 5904 5895 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auth files LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, confirmed this is PR contains only formatting except a couple of small changes to fix lints in:
- symmetric_crypto_key.rs
- cxf/import and login
- android_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Vault - confirmed only formatting/linting changes.
…ersion to 1.85 / version 2024 (bitwarden/sdk-internal#481)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26347
📔 Objective
A few newer dependencies from RustCrypto need version2024 / rust 1.85. This PR bumps the version. Rust formatting seems to have changed leading to a large diff.
All changes are either formatting changes, clippy changes, or fixing a broken build here b2eee79
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes