Skip to content

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Sep 30, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26347

📔 Objective

A few newer dependencies from RustCrypto need version2024 / rust 1.85. This PR bumps the version. Rust formatting seems to have changed leading to a large diff.

All changes are either formatting changes, clippy changes, or fixing a broken build here b2eee79

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 30, 2025

Logo
Checkmarx One – Scan Summary & Details998b90f9-a4d1-4147-b02e-e27be7f2a979

Great job! No new security vulnerabilities introduced in this pull request

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 90.40000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.55%. Comparing base (e57e64b) to head (8af25cd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-uniffi/src/platform/fido2.rs 0.00% 6 Missing ⚠️
crates/bitwarden-uniffi/src/lib.rs 0.00% 3 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   78.48%   78.55%   +0.07%     
==========================================
  Files         276      276              
  Lines       27435    27483      +48     
==========================================
+ Hits        21531    21588      +57     
+ Misses       5904     5895       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten marked this pull request as ready for review September 30, 2025 14:49
@quexten quexten requested review from a team as code owners September 30, 2025 14:49
@quexten quexten changed the title Bump version to 1.85 / version 2024 [PM-26347] Bump version to 1.85 / version 2024 Sep 30, 2025
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth files LGTM!

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed this is PR contains only formatting except a couple of small changes to fix lints in:

  • symmetric_crypto_key.rs
  • cxf/import and login
  • android_support

Copy link

@nikwithak nikwithak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Vault - confirmed only formatting/linting changes.

@quexten quexten merged commit 824c1cf into main Sep 30, 2025
54 checks passed
@quexten quexten deleted the rust/edition2024 branch September 30, 2025 18:58
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants