Skip to content

Conversation

dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Oct 2, 2025

🎟️ Tracking

📔 Objective

In #343 I've made the bindings traits always ?Send as the reqwest client on WASM is not Send. The issue is that this introduces problems for other SDK clients where that require the code to be Send, for example NAPI, which is used by Secrets Manager.

This PR updates the bindings to be ?Send only for the WASM architecture.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

sonarqubecloud bot commented Oct 2, 2025

Copy link
Contributor

github-actions bot commented Oct 2, 2025

Logo
Checkmarx One – Scan Summary & Detailsada979ab-c5c4-49bb-9e5d-8315339c864c

Great job! No new security vulnerabilities introduced in this pull request

@dani-garcia dani-garcia marked this pull request as ready for review October 2, 2025 18:29
@dani-garcia dani-garcia requested a review from a team as a code owner October 2, 2025 18:29
@dani-garcia dani-garcia requested a review from dereknance October 2, 2025 18:29
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.15%. Comparing base (dc74855) to head (add4b01).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   78.15%   78.15%           
=======================================
  Files         283      283           
  Lines       27611    27611           
=======================================
  Hits        21579    21579           
  Misses       6032     6032           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@dereknance dereknance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My eyes are crossed and I have to ice my index finger, but this PR is now approved.

@dani-garcia dani-garcia merged commit 99cca6a into main Oct 3, 2025
51 checks passed
@dani-garcia dani-garcia deleted the ps/bindings-not-send-only-wasm branch October 3, 2025 15:11
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants