-
Notifications
You must be signed in to change notification settings - Fork 20
PM-26544 - Initial create of a CLAUDE.md and a code review action #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
This looks fine to me, but I'd want @dani-garcia and @Hinton pointing out what should be in the instructions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 78.10% 78.10%
=======================================
Files 283 283
Lines 27628 27628
=======================================
Hits 21579 21579
Misses 6049 6049 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated notes about crypto seem reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny thing we should just fix and then I'll approve.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small suggestion to also mention mobile and cli in the wasm section
|
||
**Business logic in WASM** | ||
|
||
- `bitwarden-wasm-internal` contains only thin bindings. Move business logic to feature crates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably expand this section to be something like:
**Business logic in the application crates**
- `bitwarden-wasm-internal`, `bitwarden-uniffi` and `bw` contains only thin bindings. Move business logic to feature crates.
By application crates, I mean the ones that are meant to be directly used by our applications (web, mobile, cli)
…l create of a CLAUDE.md and a code review action (bitwarden/sdk-internal#493)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26544
📔 Objective
An initial creation of a Claude markdown and a code review action.
Tried to leverage both Claude and my own limited knowledge of our internal SDK to create the Claude markdown.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes