Skip to content

Conversation

theMickster
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26544

📔 Objective

An initial creation of a Claude markdown and a code review action.
Tried to leverage both Claude and my own limited knowledge of our internal SDK to create the Claude markdown.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@theMickster theMickster requested a review from a team October 6, 2025 16:49
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Logo
Checkmarx One – Scan Summary & Details2f1fcacf-4fca-4e1b-94de-da10bc3af6be

Great job! No new security vulnerabilities introduced in this pull request

@withinfocus
Copy link
Contributor

This looks fine to me, but I'd want @dani-garcia and @Hinton pointing out what should be in the instructions.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.10%. Comparing base (ae9b8b5) to head (63df571).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files         283      283           
  Lines       27628    27628           
=======================================
  Hits        21579    21579           
  Misses       6049     6049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theMickster theMickster marked this pull request as ready for review October 7, 2025 09:29
@theMickster theMickster requested a review from a team as a code owner October 7, 2025 09:29
quexten
quexten previously approved these changes Oct 7, 2025
Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated notes about crypto seem reasonable.

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny thing we should just fix and then I'll approve.

Copy link

sonarqubecloud bot commented Oct 7, 2025

@theMickster theMickster requested a review from quexten October 7, 2025 17:02
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion to also mention mobile and cli in the wasm section


**Business logic in WASM**

- `bitwarden-wasm-internal` contains only thin bindings. Move business logic to feature crates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably expand this section to be something like:

**Business logic in the application crates**

- `bitwarden-wasm-internal`, `bitwarden-uniffi` and `bw` contains only thin bindings. Move business logic to feature crates.

By application crates, I mean the ones that are meant to be directly used by our applications (web, mobile, cli)

@theMickster theMickster merged commit 292b5f6 into main Oct 8, 2025
51 checks passed
@theMickster theMickster deleted the arch/pm-26544/create-claude-code-reviews branch October 8, 2025 09:26
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants